linux-kernel - Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4BEC74C002000023000190EE@novprvlin0050.provo.novell.com>
Date:	Thu, 13 May 2010 05:53:04 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<dmitry.torokhov@...il.com>
Cc:	<mzxreary@...inter.de>, <greg@...ah.com>,
	<rpurdie@...ux.intel.com>, <mjg@...hat.com>, <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state
	 with BIOS when function key pressed

Hi Dmitry, 

Thank's for your review.

於 四，2010-05-13 於 00:52 -0700，Dmitry Torokhov 提到：
> On Wed, May 12, 2010 at 11:56:47AM -0700, Greg KH wrote:
> >  static int __init msi_init(void)
> > @@ -819,6 +875,7 @@ static void __exit msi_cleanup(void)
> >  	platform_driver_unregister(&msipf_driver);
> >  	backlight_device_unregister(msibl_device);
> >  
> > +	i8042_remove_filter(msi_laptop_i8042_filter);
> 
> You also need cancel_delayed_work_sync() here. Sorry for not noticing
> this before.
> 

Yes, you are right, need add cancel_delayed_work_sync().

Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/