linux-kernel - [PATCH 1/1] staging: hv: Fix error checking in channel.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 May 2010 15:56:30 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'virtualization@...ts.osdl.org'" <virtualization@...ts.osdl.org>,
	"'gregkh@...e.de'" <gregkh@...e.de>
CC:	Hank Janssen <hjanssen@...rosoft.com>
Subject: [PATCH 1/1]  staging: hv: Fix error checking in channel.c

From: Haiyang Zhang <haiyangz@...rosoft.com>

Subject: staging: hv: Fix error checking in channel.c
Fixed errors in return value checking code, which caused vmbus channel
not functioning.

Cc: Greg Kroah-Hartman <gregkh@...e.de>
Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
Signed-off-by: Hank Janssen <hjanssen@...rosoft.com>

---
 drivers/staging/hv/channel.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hv/channel.c b/drivers/staging/hv/channel.c
index 12c351e..f047c5a 100644
--- a/drivers/staging/hv/channel.c
+++ b/drivers/staging/hv/channel.c
@@ -204,13 +204,13 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
 					   RecvRingBufferSize) >> PAGE_SHIFT;
 
 	ret = RingBufferInit(&NewChannel->Outbound, out, SendRingBufferSize);
-	if (!ret) {
+	if (ret != 0) {
 		err = ret;
 		goto errorout;
 	}
 
 	ret = RingBufferInit(&NewChannel->Inbound, in, RecvRingBufferSize);
-	if (!ret) {
+	if (ret != 0) {
 		err = ret;
 		goto errorout;
 	}
@@ -228,7 +228,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
 					 RecvRingBufferSize,
 					 &NewChannel->RingBufferGpadlHandle);
 
-	if (!ret) {
+	if (ret != 0) {
 		err = ret;
 		goto errorout;
 	}
@@ -569,7 +569,7 @@ int VmbusChannelEstablishGpadl(struct vmbus_channel *Channel, void *Kbuffer,
 			ret = VmbusPostMessage(gpadlBody,
 					       subMsgInfo->MessageSize -
 					       sizeof(*subMsgInfo));
-			if (!ret)
+			if (ret != 0)
 				goto Cleanup;
 
 		}
-- 
1.6.3.2


Download attachment "0513-Fix-error-checking-in-channel.c.patch" of type "application/octet-stream" (1558 bytes)