linux-kernel - Re: [PATCH -next] usb: fix functionfs for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <op.vcnovimh7p4s8u@pikus>
Date:	Thu, 13 May 2010 20:12:44 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>, gregkh@...e.de
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] usb: fix functionfs for CONFIG_NET disabled

On Thu, 13 May 2010 18:41:12 +0200, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> Fix functionfs build to handle CONFIG_NET not enabled, to prevent
> these build errors:
>
> ERROR: "netif_carrier_on" [drivers/usb/gadget/g_ffs.ko] undefined!
[...]

> @@ -726,7 +726,7 @@ config USB_FUNCTIONFS
> config USB_FUNCTIONFS_ETH
>  	bool "Include CDC ECM (Ethernet) function"
> -	depends on USB_FUNCTIONFS
> +	depends on USB_FUNCTIONFS && NET
>  	help
>  	  Include an CDC ECM (Ethernet) funcion in the CDC ECM (Funcion)
>  	  Filesystem.  If you also say "y" to the RNDIS query below the
> @@ -734,7 +734,7 @@ config USB_FUNCTIONFS_ETH
> config USB_FUNCTIONFS_RNDIS
>  	bool "Include RNDIS (Ethernet) function"
> -	depends on USB_FUNCTIONFS
> +	depends on USB_FUNCTIONFS && NET
>  	help
>  	  Include an RNDIS (Ethernet) funcion in the Funcion Filesystem.
>  	  If you also say "y" to the CDC ECM query above the gadget will

Looks reasonable.  Thanks!

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/