linux-kernel - Re: [patch] libsas: dereferencing variable before check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100513184232.GC5695@bicker>
Date:	Thu, 13 May 2010 20:42:32 +0200
From:	Dan Carpenter <error27@...il.com>
To:	James Bottomley <James.Bottomley@...e.de>
Cc:	Tejun Heo <tj@...nel.org>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] libsas: dereferencing variable before check

On Thu, May 13, 2010 at 09:31:54AM -0500, James Bottomley wrote:
> On Thu, 2010-05-13 at 01:08 +0200, Tejun Heo wrote:
> > 
> > "Dan Carpenter" <error27@...il.com> wrote:
> > 
> > >The "qc->scsicmd" could be null so I moved the dereference inside the
> > >check.  This was introduced by 70b25f890: "[SCSI] fix locking around
> > >blk_abort_request()" 
> > >
> > >Signed-off-by: Dan Carpenter <error27@...il.com>
> > 
> > Ooh.. right.
> > 
> > Asked-by: Tejun Heo <tj@...nel.org>
> 
> Well, oops, yes.  Two patches to fix one bug is a bit overboard, I
> think, plus some code rearrangement to fix the locality of the problem
> and ensure it doesn't happen again might be useful.  What about this.
> 

Looks good.

Acked-by: Dan Carpenter <error27@...il.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/