linux-kernel - Re: [RFC, 6/7] NUMA hotplug emulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100513181539.GA26597@suse.de>
Date:	Thu, 13 May 2010 11:15:39 -0700
From:	Greg KH <gregkh@...e.de>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andi Kleen <ak@...ux.intel.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
	shaohui.zheng@...ux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator

On Thu, May 13, 2010 at 11:02:17AM -0700, Dave Hansen wrote:
> On Thu, 2010-05-13 at 09:56 -0700, Greg KH wrote:
> > On Thu, May 13, 2010 at 08:00:16PM +0800, Shaohui Zheng wrote:
> > > hotplug emulator:extend memory probe interface to support NUMA
> > > 
> > > Extend memory probe interface to support an extra paramter nid,
> > > the reserved memory can be added into this node if node exists.
> > > 
> > > Add a memory section(128M) to node 3(boots with mem=1024m)
> > > 
> > >       echo 0x40000000,3 > memory/probe
> 
> I dunno.  If we're going to put multiple values into the file now and
> add to the ABI, can we be more explicit about it?
> 
> 	echo "physical_address=0x40000000 numa_node=3" > memory/probe
> 
> I'd *GREATLY* prefer that over this new syntax.  The existing mechanism
> is obtuse enough, and the ',3' makes it more so.
> 
> We should have the code around to parse arguments like that, too, since
> we use it for the boot command-line.

If you are going to be doing something like this, please use configfs,
that is what it is designed for, not sysfs.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/