linux-kernel - [PATCH 19/20] fs/ceph: Use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1005132207120.6282@ask.diku.dk>
Date:	Thu, 13 May 2010 22:07:29 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Sage Weil <sage@...dream.net>, ceph-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 19/20] fs/ceph: Use kzalloc

From: Julia Lawall <julia@...u.dk>

Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
 if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@...u.dk>

---
 fs/ceph/mon_client.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -u -p a/fs/ceph/mon_client.c b/fs/ceph/mon_client.c
--- a/fs/ceph/mon_client.c
+++ b/fs/ceph/mon_client.c
@@ -481,11 +481,10 @@ int ceph_monc_do_statfs(struct ceph_mon_
 	struct ceph_mon_statfs *h;
 	int err;
 
-	req = kmalloc(sizeof(*req), GFP_NOFS);
+	req = kzalloc(sizeof(*req), GFP_NOFS);
 	if (!req)
 		return -ENOMEM;
 
-	memset(req, 0, sizeof(*req));
 	kref_init(&req->kref);
 	req->buf = buf;
 	init_completion(&req->completion);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/