linux-kernel - Re: [PATCH 16/20] drivers/platform/x86: Use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201005140001.o4E01R8r029015@turbo.physics.adelaide.edu.au>
Date:	Fri, 14 May 2010 09:31:27 +0930 (CST)
From:	Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>
To:	julia@...u.dk (Julia Lawall)
Cc:	jwoithe@...sics.adelaide.edu.au (Jonathan Woithe),
	mjg@...hat.com (Matthew Garrett),
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 16/20] drivers/platform/x86: Use kzalloc

All good from my POV.

Acked-by: Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>

> From: Julia Lawall <julia@...u.dk>
> 
> Use kzalloc rather than the combination of kmalloc and memset.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
> 
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
>  if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/platform/x86/fujitsu-laptop.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff -u -p a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -1090,10 +1090,9 @@ static int __init fujitsu_init(void)
>  	if (acpi_disabled)
>  		return -ENODEV;
>  
> -	fujitsu = kmalloc(sizeof(struct fujitsu_t), GFP_KERNEL);
> +	fujitsu = kzalloc(sizeof(struct fujitsu_t), GFP_KERNEL);
>  	if (!fujitsu)
>  		return -ENOMEM;
> -	memset(fujitsu, 0, sizeof(struct fujitsu_t));
>  	fujitsu->keycode1 = KEY_PROG1;
>  	fujitsu->keycode2 = KEY_PROG2;
>  	fujitsu->keycode3 = KEY_PROG3;
> @@ -1150,12 +1149,11 @@ static int __init fujitsu_init(void)
>  
>  	/* Register hotkey driver */
>  
> -	fujitsu_hotkey = kmalloc(sizeof(struct fujitsu_hotkey_t), GFP_KERNEL);
> +	fujitsu_hotkey = kzalloc(sizeof(struct fujitsu_hotkey_t), GFP_KERNEL);
>  	if (!fujitsu_hotkey) {
>  		ret = -ENOMEM;
>  		goto fail_hotkey;
>  	}
> -	memset(fujitsu_hotkey, 0, sizeof(struct fujitsu_hotkey_t));
>  
>  	result = acpi_bus_register_driver(&acpi_fujitsu_hotkey_driver);
>  	if (result < 0) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/