linux-kernel - Re: [PATCH 04/35] lmb: Add lmb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273824726.21352.582.camel@pasglop>
Date:	Fri, 14 May 2010 18:12:06 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Yinghai <yinghai.lu@...cle.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 04/35] lmb: Add lmb_find_area()

On Thu, 2010-05-13 at 23:25 -0700, Yinghai wrote:
> >> +u64 __lmb_find_area(u64 ei_start, u64 ei_last, u64 start, u64 end,
> >> +                    u64 size, u64 align);
> >> +u64 lmb_find_area(u64 start, u64 end, u64 size, u64 align);
> > 
> > See my comments about sorting out the return from that function.
> > 
> > Also, I don't understand the need for that __ version. It looks like
> > something you should keep inside x86, I don't see the need for it in
> the
> > generic LMB code, since it just does trivial cropping of the
> arguments.
> 
> otherwise need to export lmb_find_base() and LMB_ERROR

Well, then export lmb_find_base(), and just sanitize the result codes
over all LMB. That's not -that- hard, it's not like there were gazillion
of users yet. I don't have time now to do that myself before monday.

> yes. but need that to keep switch from early_res/nobootmem to
> lmb/nobootmem smooth.
> 
> will clean it after early_res is replaced.

Then make it inline inside the x86 stuff. But really, you should cleanup
that result code. It's something on my TODO list for lmb that I haven't
had a chance to do yet, so please look at that or wait til next week so
I do it myself.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/