[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1273824920.21352.586.camel@pasglop>
Date: Fri, 14 May 2010 18:15:20 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Yinghai <yinghai.lu@...cle.com>
Cc: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Johannes Weiner <hannes@...xchg.org>,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 08/35] x86,lmb: Add lmb_reserve_area/lmb_free_area
On Thu, 2010-05-13 at 23:30 -0700, Yinghai wrote:
> make the rebase more easy.
>
> previous version is using those api.
>
> also will add some debug print out with them
No. Get rid of them.
If any of those checks/debug is worth having in the API it's worth
having it for all archs.
At -worst-, Thomas and Peter may be ok with having inline wrappers for
the argument style conversion in x86 lmb.h but I somewhat doubt it.
In the form of non-inline exported functions with such confusing naming
and semantics (and total lack of documentation or explanation), this is
just wrong.
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists