lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 May 2010 08:54:47 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Peter Zijlstra <peterz@...radead.org> Cc: Ian Munsie <imunsie@....ibm.com>, linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>, Arnaldo Carvalho de Melo <acme@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, Tom Zanussi <tzanussi@...il.com> Subject: Re: [PATCH 2/7] perf trace: Correctly handle arrays On Fri, 2010-05-14 at 12:39 +0200, Peter Zijlstra wrote: > On Thu, 2010-05-13 at 12:32 -0400, Steven Rostedt wrote: > > > > -- Steve > > > > > + else > > > + field->elementsize = field->size; > > > + > > > *fields = field; > > > fields = &field->next; > > > > > > @@ -2101,7 +2109,8 @@ static unsigned long long eval_num_arg(void *data, int size, > > > } > > > right = eval_num_arg(data, size, event, arg->op.right); > > > val = read_size(data + larg->field.field->offset + > > > - right * long_size, long_size); > > > + right * larg->field.field->elementsize, > > > + larg->field.field->elementsize); > > > break; > > > } > > > default_op: > > > diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h > > > index 406d452..cc58a19 100644 > > > --- a/tools/perf/util/trace-event.h > > > +++ b/tools/perf/util/trace-event.h > > > @@ -40,6 +40,8 @@ struct format_field { > > > char *name; > > > int offset; > > > int size; > > > + unsigned int arraylen; > > > + unsigned int elementsize; > > > unsigned long flags; > > > }; > > > > > What's with this new fad of not trimming emails? > I usually do, but if it isn't that big I don't. But my rule (and I suspect it with others too) is that I end my comments with my sig (-- Steve). After that, I have no more comments so you do not need to look further. When I see someone's sig in the mail, I stop reading further. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists