linux-kernel - Re: [PATCH] anon_inode: set S_IFREG on the anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1273868783.2826.31.camel@localhost>
Date:	Fri, 14 May 2010 16:26:23 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	npiggin@...e.de
Subject: Re: [PATCH] anon_inode: set S_IFREG on the anon_inode

On Fri, 2010-05-14 at 21:23 +0100, Al Viro wrote:
> On Fri, May 14, 2010 at 04:05:59PM -0400, Eric Paris wrote:
> > anon_inode_mkinode() sets inode->i_mode = S_IRUSR | S_IWUSR;  This means
> > that (inode->i_mode & S_IFMT) == 0.  This trips up some SELinux code that
> > needs to determine if a given inode is a regular file, a directory, etc.
> > The easiest solution is to just make sure that the anon_inode also sets
> > S_IFREG.
> 
> How urgent that one is?  It is obvious enough, so I could include it into
> the pull request for -final, but...

printk spam.  No hurry.  Probably should have put that in the commit
message.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/