linux-kernel - Question about futex_atomic_cmpxchg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 May 2010 18:46:48 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Question about futex_atomic_cmpxchg_inatomic

Hello all,

futex_atomic_cmpxchg_inatomic is currently defined in all arch's as
something along the line of (this one is from arch/arm):

static inline int
futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval)
{
	...
}

The only user of this function is in kernel/futex.c and all of the calls
pass u32 type parameters and expect an u32 type return.

Should the all arch implementations be changed to use the u32 type, i.e?

static inline u32
futex_atomic_cmpxchg_inatomic(u32 __user *uaddr, u32 oldval, u32 newval)
{
	...
}

Regards,
Hartley