[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100514020811.GD4381@shaohui>
Date: Fri, 14 May 2010 10:08:11 +0800
From: Shaohui Zheng <shaohui.zheng@...el.com>
To: Wu Fengguang <fengguang.wu@...el.com>
Cc: Greg KH <gregkh@...e.de>, akpm@...ux-foundation.org,
linux-mm@...ck.org, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
Andi Kleen <ak@...ux.intel.com>,
Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
shaohui.zheng@...ux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
On Fri, May 14, 2010 at 10:05:26AM +0800, Wu Fengguang wrote:
> On Fri, May 14, 2010 at 09:49:02AM +0800, Zheng, Shaohui wrote:
> > On Thu, May 13, 2010 at 09:56:03AM -0700, Greg KH wrote:
> > > On Thu, May 13, 2010 at 08:00:16PM +0800, Shaohui Zheng wrote:
> > > > hotplug emulator:extend memory probe interface to support NUMA
> > > >
> > > > Extend memory probe interface to support an extra paramter nid,
> > > > the reserved memory can be added into this node if node exists.
> > > >
> > > > Add a memory section(128M) to node 3(boots with mem=1024m)
> > > >
> > > > echo 0x40000000,3 > memory/probe
> > > >
> > > > And more we make it friendly, it is possible to add memory to do
> > > >
> > > > echo 3g > memory/probe
> > > > echo 1024m,3 > memory/probe
> > > >
> > > > It maintains backwards compatibility.
> > >
> > > Again, please document this.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > okay
>
> Shaohui, it's useless to document a wrong interface.
> Better to fix the interface _first_, then document becomes meaningful.
Fenggunag,
greg reminds me to add the docment into Documentation/ABI/, We miss it in
the RFC. Currently, the interface format is not finalized, when we decide the
final interface, the last step is documenting it in.
>
> Thanks,
> Fengguang
--
Thanks & Regards,
Shaohui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists