linux-kernel - Re: [PATCH] MFD: rdc321x: change resources flags to IORESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 15 May 2010 22:58:13 +0200
From:	Florian Fainelli <florian@...nwrt.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MFD: rdc321x: change resources flags to IORESOURCE_IO

Le samedi 15 mai 2010 22:12:58,  Fainelli a écrit :
> The rdc321x southbridge PCI device has no MEM PCI resources that we could
> pass to mfd_add_devices. Since 33254dd5, mfd_add_device checks for the
> mem_base argument that we set to NULL. Changing the resources passed to
> our MFD cells from IORESOURCE_MEM to IORESOURCE_IO fixes that. Since we use
> those resources as offsets to the PCI configuration space base address of
> the southbridge device this is also more adequate.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
> index e344907..9ec3c51 100644
> --- a/drivers/gpio/rdc321x-gpio.c
> +++ b/drivers/gpio/rdc321x-gpio.c
> @@ -147,7 +147,7 @@ static int __devinit rdc321x_gpio_probe(struct
>  platform_device *pdev) return -ENOMEM;
>  	}
> 
> -	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "gpio-reg1");
> +	r = platform_get_resource_byname(pdev, IORESOURCE_IO, "gpio-reg1");
>  	if (!r) {
>  		dev_err(&pdev->dev, "failed to get gpio-reg1 resource\n");
>  		err = -ENODEV;

I missed one hunk here, please discard this version of the patch.

> diff --git a/drivers/mfd/rdc321x-southbridge.c
>  b/drivers/mfd/rdc321x-southbridge.c index 256dd56..5092297 100644
> --- a/drivers/mfd/rdc321x-southbridge.c
> +++ b/drivers/mfd/rdc321x-southbridge.c
> @@ -34,7 +34,7 @@ static struct resource rdc321x_wdt_resource[] = {
>  		.name	= "wdt-reg",
>  		.start	= RDC321X_WDT_CTRL,
>  		.end	= RDC321X_WDT_CTRL + 0x3,
> -		.flags	= IORESOURCE_MEM,
> +		.flags	= IORESOURCE_IO,
>  	}
>  };
> 
> @@ -47,12 +47,12 @@ static struct resource rdc321x_gpio_resources[] = {
>  		.name	= "gpio-reg1",
>  		.start	= RDC321X_GPIO_CTRL_REG1,
>  		.end	= RDC321X_GPIO_CTRL_REG1 + 0x7,
> -		.flags	= IORESOURCE_MEM,
> +		.flags	= IORESOURCE_IO,
>  	}, {
>  		.name	= "gpio-reg2",
>  		.start	= RDC321X_GPIO_CTRL_REG2,
>  		.end	= RDC321X_GPIO_CTRL_REG2 + 0x7,
> -		.flags	= IORESOURCE_MEM,
> +		.flags	= IORESOURCE_IO,
>  	}
>  };
> 
> diff --git a/drivers/watchdog/rdc321x_wdt.c
>  b/drivers/watchdog/rdc321x_wdt.c index 4733a99..428f8a1 100644
> --- a/drivers/watchdog/rdc321x_wdt.c
> +++ b/drivers/watchdog/rdc321x_wdt.c
> @@ -237,7 +237,7 @@ static int __devinit rdc321x_wdt_probe(struct
>  platform_device *pdev) return -ENODEV;
>  	}
> 
> -	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "wdt-reg");
> +	r = platform_get_resource_byname(pdev, IORESOURCE_IO, "wdt-reg");
>  	if (!r) {
>  		dev_err(&pdev->dev, "failed to get wdt-reg resource\n");
>  		return -ENODEV;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/