linux-kernel - Re: [PATCH] mm: Consider the entire user address space during node migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 May 2010 23:31:16 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Greg Thelen <gthelen@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	Mel Gorman <mel@....ul.ie>, kamezawa.hiroyu@...fujitsu.com,
	nishimura@....nes.nec.co.jp, balbir@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Consider the entire user address space during node 
	migration

Hi

Mysteriously, I haven't receive original post.
So now I'm guessing you acked following patch.

http://lkml.org/lkml/2010/5/14/393

but I don't think it is correct.

> -	check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> +	check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> 			flags | MPOL_MF_DISCONTIG_OK, &pagelist);

Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
Please put following line anywhere.

#define TASK_SIZE_MAX TASK_SIZE


But this patch is conceptually good. if it fixes the bug. I'll ack gladly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/