linux-kernel - Re: [PATCH] x86: Export tsc related information in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 May 2010 07:37:37 -0700
From:	Venkatesh Pallipadi <venki@...gle.com>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Chris Mason <chris.mason@...cle.com>,
	linux-kernel@...r.kernel.org,
	Dan Magenheimer <dan.magenheimer@...cle.com>
Subject: Re: [PATCH] x86: Export tsc related information in sysfs

On Sat, May 15, 2010 at 5:35 AM, Jaswinder Singh Rajput
<jaswinderlinux@...il.com> wrote:
> Hello,
>> +
>> +static int __init init_tsc_sysfs(void)
>> +{
>> +       int err, i = 0;
>> +
>> +       err = sysdev_class_register(&tsc_sysclass);
>> +       if (err)
>> +               return err;
>> +
>> +       err = sysdev_register(&device_tsc);
>> +       if (err)
>> +               goto fail;
>
> fail will call sysdev_unregister(&device_tsc) which is not
> appropriate, please fix this goto.
>

Thanks for catching this. Will fix this in the patch refresh.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/