linux-kernel - Re: [RFC,2/7] NUMA Hotplug emulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100515160805.GA23630@shaohui>
Date:	Sun, 16 May 2010 00:08:05 +0800
From:	Shaohui Zheng <shaohui.zheng@...el.com>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Mel Gorman <mel@....ul.ie>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	linux-kernel@...r.kernel.org, ak@...ux.intel.co,
	fengguang.wu@...el.com, haicheng.li@...ux.intel.com,
	shaohui.zheng@...ux.intel.com
Subject: Re: [RFC,2/7] NUMA Hotplug emulator

On Sat, May 15, 2010 at 06:47:00PM +0530, Jaswinder Singh Rajput wrote:
> > +       if (hidden_num)
> 
> if (hidden_num) is not required, as next line's for statement is also
> doing the same thing.

Good catching, We will remove this statement in the formal patch. Thanks Jaswinder.

Have a nice day.

> 
> Thanks,
> --
> Jaswinder Singh.
> 
> > +               for (i = 0; i < hidden_num; i++) {
> > +                       int nid = num_nodes + i + 1;
> > +                       node_set(nid, node_possible_map);
> > +                       hidden_nodes[nid].start = hp_start + hp_size * i;
> > +                       hidden_nodes[nid].end = hp_start + hp_size * (i+1);
> > +                       node_set_hidden(nid);
> > +               }
> > +}

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/