linux-kernel - Re: [PATCH] Staging: quatech_usb2: Convert eos semaphore to mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100516134540.7dd69473@infradead.org>
Date:	Sun, 16 May 2010 13:45:40 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Alessio Igor Bogani <abogani@...ware.it>
Cc:	Oliver Neukum <oliver@...kum.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	Jiri Kosina <jkosina@...e.cz>,
	Javier Martinez Canillas <martinez.javier@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: quatech_usb2: Convert eos semaphore to mutex

On Sun, 16 May 2010 00:08:30 +0200
Alessio Igor Bogani <abogani@...ware.it> wrote:

> Hi Oliver,
> 
> 2010/5/15 Oliver Neukum <oliver@...kum.org>:
> > Am Samstag, 15. Mai 2010 23:40:02 schrieb Alessio Igor Bogani:
> >> The eos semaphore is used as a mutex so replace it with a real
> >> mutex.
> >
> > Documentation/mutex-design.txt states that a mutex must not be used
> > from within an interrupt handler. Is this outdated?
> 
> You are right. Simply I didn't see irqreturn_t return type in function
> prototype.
> 
> Sorry for my mistake.
> 

you might want to convert it to a completion....
that sounds more the usage model that the driver here is doing


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/