| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100516225355.GF3236@sortiz.org> Date: Mon, 17 May 2010 00:53:55 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Rabin Vincent <rabin.vincent@...ricsson.com> Cc: linux-kernel@...r.kernel.org, STEricsson_nomadik_linux@...t.st.com, Linus Walleij <linus.walleij@...ricsson.com>, Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com> Subject: Re: [PATCH] mfd: new AB8500 driver Hi Rabin, On Tue, May 11, 2010 at 10:15:31AM +0530, Rabin Vincent wrote: > Add a new driver to support the AB8500 Power Management chip, replacing > the current AB4500. The new driver replaces the old one, instead of an > incremental modification, because this is a substantial overhaul > including: > > - Split of the driver into -core and -spi portions, to allow another > interface layer to be added > > - Addition of interrupt support > > - Switch to MFD core API for handling subdevices > > - Simplification of the APIs to remove a redundant block parameter > > - Rename of the APIs and macros from ab4500_* to ab8500_* > > - Rename of the files from ab4500* to ab8500* > > The driver still identifes itself as "ab4500" The patch looks good, but why not changing that to "ab8500" and integrating the relevant board file changes to this patch ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists