linux-kernel - Re: [PATCH 1/8] buffer: make invalidate_bdev() drain all percpu LRU add caches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 May 2010 00:11:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	jeff@...zik.org, linux-ide@...r.kernel.org, jens.axboe@...cle.com,
	linux-scsi@...r.kernel.org, James.Bottomley@...e.de,
	linux-kernel@...r.kernel.org, ben@...adent.org.uk,
	bzolnier@...il.com
Subject: Re: [PATCH 1/8] buffer: make invalidate_bdev() drain all percpu
 LRU add caches

From: Tejun Heo <tj@...nel.org>
Date: Sat, 15 May 2010 20:09:27 +0200

> invalidate_bdev() should release all page cache pages which are clean
> and not being used; however, if some pages are still in the percpu LRU
> add caches on other cpus, those pages are considered in used and don't
> get released.  Fix it by calling lru_add_drain_all() before trying to
> invalidate pages.
> 
> This problem was discovered while testing block automatic native
> capacity unlocking.  Null pages which were read before automatic
> unlocking didn't get released by invalidate_bdev() and ended up
> interfering with partition scan after unlocking.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/