linux-kernel - Re: [PATCH] x86: CPU detection for RDC System-on-Chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100516141917.0d2e69e2@lxorguk.ukuu.org.uk>
Date:	Sun, 16 May 2010 14:19:17 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	mingo@...e.hu, "linux-kernel" <linux-kernel@...r.kernel.org>,
	andi@...stfloor.org
Subject: Re: [PATCH] x86: CPU detection for RDC System-on-Chip

> +	case 0x00321004:  /* tested */
> +		strcpy(c->x86_model_id, "S3282/CodeTek");
> +		break;
> +	case 0x00321007:
> +		strcpy(c->x86_model_id, "R8610");
> +		break;
> +	default:
> +		pr_info("RDC CPU: Unrecognised Customer ID (0x%x) please "
> +			"report to: linux-kernel@...r.kernel.org\n",
> +			customer_id);

Surely this should be a break as you want to set the vendor. You've
established its an RDC at this point have you not - so you want to set
x86_vendor.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/