linux-kernel - Re: [PATCH] x86: unify current 3 similar ways of saving IRQ info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1005171016150.3368@localhost.localdomain>
Date:	Mon, 17 May 2010 10:16:40 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Feng Tang <feng.tang@...el.com>
cc:	Ingo Molnar <mingo@...e.hu>, "H.Peter Anvin" <hpa@...or.com>,
	"Brown, Len" <len.brown@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Pan, Jacob jun" <jacob.jun.pan@...el.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: unify current 3 similar ways of saving IRQ info

On Mon, 17 May 2010, Feng Tang wrote:

> On Mon, 17 May 2010 16:07:05 +0800
> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > On Mon, 17 May 2010, Feng Tang wrote:
> > 
> > >  {
> > >  	if (mp_irq->dstapic != m->dstapic)
> > > @@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct
> > > mpc_intsrc *mp_irq, return 0;
> > >  }
> > >  
> > > -static void __init MP_intsrc_info(struct mpc_intsrc *m)
> > > +/* Will also be called in acpi/sfi related code */
> > > +void mp_save_irq(struct mpc_intsrc *m)
> > 
> >   Again, this code is called from __init context only and should stay
> >   __init.
> 
> Hi Thomas,
> 
> The reason I removed the __init is it will be called by non __init functions
> from acpi/boot.c and mrst.c

Why should that happen ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/