linux-kernel - Re: [PATCH 21/37] drivers/hid: Use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005171026500.28092@pobox.suse.cz>
Date:	Mon, 17 May 2010 10:27:37 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Julia Lawall <julia@...u.dk>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 21/37] drivers/hid: Use kmemdup

On Sat, 15 May 2010, Julia Lawall wrote:

> From: Julia Lawall <julia@...u.dk>
> 
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
> 
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
> 
> -  to = \(kmalloc\|kzalloc\)(size,flag);
> +  to = kmemdup(from,size,flag);
>    if (to==NULL || ...) S
> -  memcpy(to, from, size);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/hid/hid-core.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -u -p a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -653,10 +653,9 @@ int hid_parse_report(struct hid_device *
>  	if (device->driver->report_fixup)
>  		device->driver->report_fixup(device, start, size);
>  
> -	device->rdesc = kmalloc(size, GFP_KERNEL);
> +	device->rdesc = kmemdup(start, size, GFP_KERNEL);
>  	if (device->rdesc == NULL)
>  		return -ENOMEM;
> -	memcpy(device->rdesc, start, size);
>  	device->rsize = size;
>  
>  	parser = vmalloc(sizeof(struct hid_parser));

Applied, thanks Julia.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/