lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 May 2010 13:29:40 +0200 From: Frederic Weisbecker <fweisbec@...il.com> To: Stephane Eranian <eranian@...gle.com> Cc: linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu, paulus@...ba.org, davem@...emloft.net, acme@...radead.org, perfmon2-devel@...ts.sf.net, eranian@...il.com Subject: Re: [PATCH] perf: fix bug mismatch with -c option definition On Mon, May 17, 2010 at 12:04:01PM +0200, Stephane Eranian wrote: > The -c option defines the user requested sampling period. It was implemented > using an unsigned int variable but the type of the option was OPT_LONG. Thus, > the option parser was overwriting memory belonging to other variables, namely > the mmap_pages leading to a zero page sampling buffer. The bug was exposed > only when compiling at -O0, probably because the compiler was padding > variables at higher optimization levels. > > This patch fixes this problem by declaring user_interval as u64. This also > avoids wrap-around issues for large period on 32-bit systems. > > Signed-off-by: Stephane Eranian <eranian@...gle.com> Acked-by: Frederic Weisbecker <fweisbec@...il.com> Small detail: could you avoid the spaces in the beginning of your changelog lines? May be that's because you use git-show to dump your patches? In which case I suggest you to use git-format-patch instead. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists