linux-kernel - Re: [PATCH] DMA: PL330: Add dma api driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikeRmB7DdO1Nrvzz-jVV8CmISA5C_9f2kgpeLEO@mail.gmail.com>
Date:	Mon, 17 May 2010 21:58:35 +0900
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Jassi Brar <jassi.brar@...sung.com>, jy0922.shim@...sung.com,
	linus.ml.walleij@...il.com, maciej.sosnowski@...el.com,
	linux-kernel@...r.kernel.org, ben-linux@...ff.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] DMA: PL330: Add dma api driver

On Mon, May 17, 2010 at 6:55 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Tue, May 11, 2010 at 10:23 PM, Jassi Brar <jassi.brar@...sung.com> wrote:

>> +static void dma_pl330_rqcb(void *token, enum pl330_op_err err)
>> +{
>> +       struct dma_pl330_desc *desc = token;
>> +       struct dma_pl330_chan *pch = desc->pchan;
>> +       unsigned long flags;
>> +
>> +       /* If desc aborted */
>> +       if (!pch)
>> +               return;
>> +
>> +       spin_lock_irqsave(&pch->lock, flags);
>> +
>> +       desc->status = DONE;
>> +
>> +       spin_unlock_irqrestore(&pch->lock, flags);
>
> I don't think you need the lock here.  Assigning an integer is atomic,
> and you reschedule the tasklet.
yes right

> Since this patch depends on the generic bits in Russell's tree I need
> to wait until after the ARM tree is pulled to take it through the dma
> tree.  So, for now...
>
> Acked-by: Dan Williams <dan.j.williams@...el.com>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/