linux-kernel - Re: [uml-devel] [PATCH] UML: x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTiks4xC4ecImFzaFBpLdBp7l7iUO941fYyCetxTA@mail.gmail.com>
Date:	Mon, 17 May 2010 16:42:23 +0200
From:	Paolo Giarrusso <p.giarrusso@...il.com>
To:	Nicolas Thill <nicolas.thill@...il.com>
Cc:	Jeff Dike <jdike@...toit.com>, Nicolas Thill <nico@...nwrt.org>,
	linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [uml-devel] [PATCH] UML: x86_64: fix memcpy export

Shouldn't this thing be in arch/um/sys-i386/ksyms.c, instead of having #ifndef?

On Mon, May 3, 2010 at 01:58, Nicolas Thill <nicolas.thill@...il.com> wrote:
> ./arch/um/sys-x86_64/ksyms.c exports memcpy or __memcpy depending on the gcc
> version, use the same logic in ./arch/um/os-Linux/user_syms.c
>
> Signed-off-by: Nicolas Thill <nico@...nwrt.org>
> ---
>  arch/um/os-Linux/user_syms.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/os-Linux/user_syms.c b/arch/um/os-Linux/user_syms.c
> index 89b48a1..e3a12dd 100644
> --- a/arch/um/os-Linux/user_syms.c
> +++ b/arch/um/os-Linux/user_syms.c
> @@ -23,7 +23,8 @@ extern int printf(const char *, ...);
>  EXPORT_SYMBOL(strstr);
>  #endif
>
> -#ifndef __x86_64__
> +#if !defined(__x86_64) || \
> +       (__GNUC__ == 4 && __GNUC_MINOR__ < 3) || (__GNUC__ < 4)
>  extern void *memcpy(void *, const void *, size_t);
>  EXPORT_SYMBOL(memcpy);
>  #endif
> --
> 1.6.0.4
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> User-mode-linux-devel mailing list
> User-mode-linux-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
>



-- 
Paolo Giarrusso
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/