linux-kernel - Re: [PATCH 2/2]: atomic_t: Remove volatile from atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1005170800100.4195@i5.linux-foundation.org>
Date:	Mon, 17 May 2010 08:01:54 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Anton Blanchard <anton@...ba.org>
cc:	akpm@...ux-foundation.org, willy@...ux.intel.com,
	benh@...nel.crashing.org, paulus@...ba.org,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2]: atomic_t: Remove volatile from atomic_t
 definition



On Mon, 17 May 2010, Anton Blanchard wrote:
> 
> It turns out this bad code is a result of us defining atomic_t as a
> volatile int.

Heh. Ok, as you point out in the commit message, I obviously agree with 
this patch. "volatile" on data is evil, with the possible exception of 
"jiffies" type things.

So applied.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/