linux-kernel - Re: [PATCH 1/1] regulator: return set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100517153431.GA6218@opensource.wolfsonmicro.com>
Date:	Mon, 17 May 2010 08:34:32 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sundar R Iyer <sundar.iyer@...ricsson.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Subject: Re: [PATCH 1/1] regulator: return set_mode is same mode is
 requested

On Mon, May 17, 2010 at 08:45:45PM +0530, Sundar R Iyer wrote:

> +	/* sanity check */
> +	if (!rdev->desc->ops->get_mode) {
> +		ret = -EINVAL;
> +		goto out;
> +	}

This doesn't seem like the right error handling - if the driver has a
set_mode() you'd *expect* it to have a get_mode() but there's no need
for it to be a strict requirement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/