linux-kernel - Re: [PATCH 2.6.34-rc7 v4] HID: hid-samsung: add support for Creative Desktop Wireless 6000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BF178BD.2000209@yahoo.de>
Date:	Mon, 17 May 2010 19:11:25 +0200
From:	Robert Schedel <r.schedel@...oo.de>
To:	dhprince.devel@...oo.co.uk, Jiri Kosina <jkosina@...e.cz>
CC:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.34-rc7 v4] HID: hid-samsung: add support for Creative
 Desktop Wireless 6000

Hello,

sorry for one late observation:

On 17.05.2010 12:42, Don Prince wrote:
> Add support for the multimedia buttons of the Creative Desktop Wireless
> 6000 keyboard/mouse combo which are not currently handled by the
> default/samsung HID driver.
> 
> Signed-off-by: Don Prince <dhprince-devel@...oo.co.uk>
> 
> ---
> 
> Added comments as requested by Robert Schedel <r.schedel@...oo.de>
> 
> As requested by Jiri Kosina, made key mapping code more concise
> i.e. ignored checkpatch.pl's wingeing about code style.
[...]
> +	switch (usage->hid & HID_USAGE) {
> +	/* report 2 */
> +	case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
> +	case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
> +	case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
> +	case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
> +	case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
> +	case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
> +	case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;

Those seven are identical to hid-input.c mapping (HUT 1.1 compliant) and could simply be deleted. Daisy chaining via default case below, right?

> +	case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break;
> +	case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL);	break;
> +	case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break;
> +	case 0x197: samsung_kbd_mouse_map_key_clear(KEY_COMPUTER); break;
> +	case 0x22b: samsung_kbd_mouse_map_key_clear(KEY_SEARCH); break;
> +	case 0x22c: samsung_kbd_mouse_map_key_clear(KEY_WWW); break;
> +	case 0x22d: samsung_kbd_mouse_map_key_clear(KEY_BACK); break;
> +	case 0x22e: samsung_kbd_mouse_map_key_clear(KEY_FORWARD); break;
> +	case 0x22f: samsung_kbd_mouse_map_key_clear(KEY_FAVORITES); break;
> +	case 0x230: samsung_kbd_mouse_map_key_clear(KEY_REFRESH); break;
> +	case 0x231: samsung_kbd_mouse_map_key_clear(KEY_STOP); break;
> +	default:
> +		return 0;

Regards,
Robert Schedel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/