linux-kernel - Re: [PATCH] serial: apbuart: Let boards without apbuart boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BF0E422.1070609@gaisler.com>
Date:	Mon, 17 May 2010 08:37:22 +0200
From:	Kristoffer Glembo <kristoffer@...sler.com>
To:	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
CC:	Anton Vorontsov <cbouatmailru@...il.com>,
	David Miller <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: apbuart: Let boards without apbuart boot

Hi,

Miguel Ojeda wrote:
> On Sun, May 16, 2010 at 12:20 PM, Anton Vorontsov
> <cbouatmailru@...il.com> wrote:
>> On Sun, May 16, 2010 at 10:41:50AM +0200, Miguel Ojeda wrote:
>>> On Fri, May 14, 2010 at 4:19 PM, Anton Vorontsov <avorontsov@...sta.com> wrote:
>>>> This patch fixes the following oops:
>>>>
>>> I sent a patch that fixes that oops too. It is in mm right now. Please check it.
>> Hm, and my patch is in Greg's tree already...
> 
> Well, that's weird... Andrew sent an email to Greg 4 days ago with the
> patch after Kristoffer ack'ed it. Maybe Greg missed it.
> 
>> Greg, if it didn't make it anywhere further your tree, please
>> drop it in favour of Miguel's patch, Miguel was the first who
>> sent a fix for this problem.
>>
> 
> Thanks, but Kristoffer should review your patch too, as they are not
> exactly the same: My patch changes does an additional check at
> grlib_apbuart_init() (which also calls grlib_apbuart_configure()),
> sets the global variable grlib_apbuart_port_nr to 0 and prints a
> message to the user; keeping the void return type of
> grlib_apbuart_configure().


Let's run with Miguels patch as it fixes the calls to grlib_apbuart_configure()
from both grlib_apbuart_init() and apbuart_console_init().

So Greg could you please drop Anton patch?

Anton if you want to please send a new patch annotating grlib_apbuart_configure
with __init though.

Best regards,
Kristoffer Glembo
Aeroflex Gaisler

 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/