linux-kernel - Re: [tip:perf/core] perf probe: Don't compile CFI related code if elfutils is old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTilWR9fEWBOZLyvFcU6DR6i9aswpSRzFnlIiSoNm@mail.gmail.com>
Date:	Tue, 18 May 2010 11:39:58 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Robert Richter <robert.richter@....com>
Cc:	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"acme@...hat.com" <acme@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mhiramat@...hat.com" <mhiramat@...hat.com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:perf/core] perf probe: Don't compile CFI related code if 
	elfutils is old

On Tue, May 18, 2010 at 11:35 AM, Robert Richter <robert.richter@....com> wrote:
> On 17.05.10 21:57:38, tip-bot for Masami Hiramatsu wrote:
>> Commit-ID:  7752f1b096e13991f20b59fd11ba73da3809d93c
>> Gitweb:     http://git.kernel.org/tip/7752f1b096e13991f20b59fd11ba73da3809d93c
>> Author:     Masami Hiramatsu <mhiramat@...hat.com>
>> AuthorDate: Mon, 10 May 2010 13:12:07 -0400
>> Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
>> CommitDate: Mon, 17 May 2010 22:13:51 -0300
>>
>> perf probe: Don't compile CFI related code if elfutils is old
>>
>> Check elfutils version, and if it is old don't compile CFI analysis code. This
>> allows to compile perf with old elfutils.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@...hat.com>
>> Tested-by: Stephane Eranian <eranian@...gle.com>
>> Reported-by: Robert Richter <robert.richter@....com>
>> Cc: Ingo Molnar <mingo@...e.hu>
>> LKML-Reference: <20100510171207.26029.97604.stgit@...alhost6.localdomain6>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>> ---
>
> I think this patch is not needed as we came up with an alternative
> solution with commit:
>
>  6b3c4ef perf probe: Check older elfutils and set NO_DWARF
>
But I am compiling tip, so this patch is in and I still got the problem.
It is because the test program does not check for Dwarf_CFI so it
assumes you have the right version of libdw.

If I understand Masami's patch, you can still compile dwarf support
in despite the lack of Dwarf_CFI.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/