linux-kernel - Re: [PATCH] blkdev: cgroup whitelist permission fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100518044525.GA5625@us.ibm.com>
Date:	Mon, 17 May 2010 23:45:25 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	"Daniel P. Berrange" <berrange@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blkdev: cgroup whitelist permission fix

Quoting Chris Wright (chrisw@...s-sol.org):
> The cgroup device whitelist code gets confused when trying to grant
> permission to a disk partition that is not currently open.  Part of
> blkdev_open() includes __blkdev_get() on the whole disk.  This simply
> avoids the cgroup check for the whole disk case when opening a
> partition.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=589662
> 
> Signed-off-by: Chris Wright <chrisw@...s-sol.org>

Thanks, Chris, sorry for the delay.

Acked-by: Serge E. Hallyn <serue@...ibm.com>
Tested-by: Serge E. Hallyn <serue@...ibm.com>

> ---
>  fs/block_dev.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 6dcee88..d4d19ac 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1192,10 +1192,12 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
>  	/*
>  	 * hooks: /n/, see "layering violations".
>  	 */
> -	ret = devcgroup_inode_permission(bdev->bd_inode, perm);
> -	if (ret != 0) {
> -		bdput(bdev);
> -		return ret;
> +	if (!for_part) {
> +		ret = devcgroup_inode_permission(bdev->bd_inode, perm);
> +		if (ret != 0) {
> +			bdput(bdev);
> +			return ret;
> +		}
>  	}
> 
>  	lock_kernel();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/