linux-kernel - Re: [PATCH] power/ds2760_battery: document ABI change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100519083422.GA31202@oksana.dev.rtsoft.ru>
Date:	Wed, 19 May 2010 12:34:22 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Daniel Mack <daniel@...aq.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	kay.sievers@...y.org, dwmw2@...radead.org,
	broonie@...nsource.wolfsonmicro.com, len.brown@...el.com,
	astarikovskiy@...e.de, mreimer@...p.net, zbr@...emap.net,
	tj@...nel.org
Subject: Re: [PATCH] power/ds2760_battery: document ABI change

On Tue, May 18, 2010 at 10:30:49PM +0200, Daniel Mack wrote:
> >From 7ed6b078c1cb718509a0faf79ac53f768fa5cfc4 Mon Sep 17 00:00:00 2001
> From: Daniel Mack <daniel@...aq.de>
> Date: Tue, 18 May 2010 22:26:40 +0200
> Subject: [PATCH] power/ds2760_battery: document ABI change
> 
> Add some documentation for the newly added writeable properties.
> 

I added 'Suggested-by: Greg KH <gregkh@...e.de>' tag here.

> Signed-off-by: Daniel Mack <daniel@...aq.de>
> ---
> On Tue, May 18, 2010 at 12:56:24PM -0700, Greg KH wrote:
> > On Tue, May 18, 2010 at 09:49:52PM +0200, Daniel Mack wrote:
> > > This patch adds support for writeable power supply properties and
> > > exposes them as writeable to sysfs.
> > 
> > Please properly document this in Documentation/ABI as you are changing
> > the userspace ABI.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Is something like the following appropriate?

Looks good to me, as well as patches 1-3 (though in the first patch
I fixed power_supply_attr_groups to be static, it was a negligence
from my original patch).

I applied all these patches to battery-2.6.git, thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/