linux-kernel - Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100519105305.54804b57@lxorguk.ukuu.org.uk>
Date:	Wed, 19 May 2010 10:53:05 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	Rupjyoti Sarmah <rsarmah@...c.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, jgarzik@...ox.com, sr@...x.de,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission
 >

On Wed, 19 May 2010 10:49:59 +0900
Jassi Brar <jassisinghbrar@...il.com> wrote:

> On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah@...c.com> wrote:
> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
> 
> The controller seems to be a thrid party IP (from Synopsys) in your
> SoC and there are many chances the IP will appear in some other
> SOCs too. This implementation doesn't seem to take care of that
> scenario.

I'd question if that is worth it seriously. At the point there are
multiple users of the device you know what it will look like. Until then
you neither know if the work is needed nor what will require abstracting.

Lazy evaluation is good for code too ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/