linux-kernel - Re: [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping changes on 64bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BF3D0A8.9050509@linux.intel.com>
Date:	Wed, 19 May 2010 19:51:04 +0800
From:	Haicheng Li <haicheng.li@...ux.intel.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"dnelson@...hat.com" <dnelson@...hat.com>,
	Andi Kleen <andi@...stfloor.org>,
	"Li, Haicheng" <haicheng.li@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping	changes
 on 64bit.

I'm sorry for my slow response ...

Wu Fengguang wrote:
 >> +static void sync_global_pgds(unsigned long start, unsigned long end)
 >
 > It seems that this function can reuse code with vmalloc_sync_all().

agreed.

 > __init_extra_mapping() is not related to memory hotplug (note: the
 > __init prefix), so not necessary to change this function?

yes, I think you are right. We don't need to change __init_extra_mapping().

 >>   vmemmap_populate(struct page *start_page, unsigned long size, int node)
 > It's not necessary to introduce the "start" and "err" variables.
 > It helps simplify the patch (or you can put them to another cleanup
 > only patch).

ok, let's make the fix as simple as possible.

I'll send out the revised version right now. Thank you for the review.

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/