linux-kernel - Re: [GIT PULL] x86/atomic changes for v2.6.35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100520012124.ec269c14.sfr@canb.auug.org.au>
Date:	Thu, 20 May 2010 01:21:24 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Ingo Molnar <mingo@...e.hu>,
	Luca Barbieri <luca@...a-barbieri.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arch@...r.kernel.org
Subject: Re: [GIT PULL] x86/atomic changes for v2.6.35

On Wed, 19 May 2010 08:01:35 -0700 "H. Peter Anvin" <hpa@...or.com> wrote:
>
> It was discussed on linux-kernel -- note that there is no breakage for
> smaller architectures unless you enable the test directly or via randconfig.

or allmodconfig or allyesconfig.

> The other part is that generic atomic64_t has been available since
> middle of 2009, and was *also* discussed extensively on linux-kernel --
> in fact, several of the smaller architectures added support at that
> time.  That the breakage occurred because of an inconsequential test
> rather than real code is thus really nothing but fortunate.

I don't disagree with any of that (except that an m68k allmodconfig build
may well build fine without the test being built so maybe building the
test needs a dependency).

My point was that I keep hearing the "Linus said it is OK to break the
other architectures" argument brought up where it really is not even
relevant to the conversation.  If anything, I guess Geert was taking a
little dig at me because his problem should have been noticed among my
build results. Unfortunately even I don't check all the build results all
the time (I guess I hope that maintainers may have time to check them out
once in a while).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped