linux-kernel - Re: [PATCH 2/2] Hyperv detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BF42C3D.6030404@zytor.com>
Date:	Wed, 19 May 2010 11:21:49 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Greg KH <greg@...ah.com>
CC:	Ky Srinivasan <ksrinivasan@...ell.com>, hjanssen@...rosoft.com,
	mingo@...hat.com, linux-kernel@...r.kernel.org,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH 2/2] Hyperv detection - code cleanup

On 05/19/2010 11:19 AM, Greg KH wrote:
> On Wed, May 19, 2010 at 10:50:54AM -0700, H. Peter Anvin wrote:
>> On 05/19/2010 10:20 AM, Ky Srinivasan wrote:
>>> From: K. Y. Srinivasan <ksrinivasan@...ell.com>
>>> Subject: Code cleanup - get rid of the "ms" prefix in hyperv related files.  
>>>
>>>
>>> Signed-off-by: K. Y. Srinivasan <ksrinivasan@...ell.com>
>>
>> NAK in the extreme.
>>
>> "hyperv" -- without the capitalization to make it stand out -- is way
>> too easy to read as just an abbreviation for "hypervisor".
> 
> Which is what I confused it with, and hence I wrote the ms_* changes in
> my patch.  But KY wanted it changed back so I suggested he write a
> patch.
> 
> I personally like the ms_ stuff, it makes it more obvious what is going
> on here, but that's just me.
> 

Well, I agree with you.  Sorry, Ky.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/