linux-kernel - Re: [PATCH 1/2] Hyperv detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BF444A9.6090709@zytor.com>
Date:	Wed, 19 May 2010 13:06:01 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Avi Kivity <avi@...hat.com>
CC:	Ky Srinivasan <ksrinivasan@...ell.com>, greg@...ah.com,
	hjanssen@...rosoft.com, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Hyperv detection - code cleanup

On 05/19/2010 11:47 AM, Avi Kivity wrote:
> On 05/19/2010 08:51 PM, H. Peter Anvin wrote:
>> On 05/19/2010 10:12 AM, Ky Srinivasan wrote:
>>    
>>> From: K. Y. Srinivasan<ksrinivasan@...ell.com>
>>> Subject: Code cleanup - consolidate all hyperv related definitions into one
>>> header file.
>>>
>>>      
>> How will this affect KVM?  I was under the impression that this was
>> separated out as a constants-only header file for a reason.
> 
> It's exported, so any types need to be compatible with userspace (i.e. 
> __u32).
> 

... and certainly no prototypes for kernel-only functionality.
Right, that's what I thought.  So NAK on this patch, too.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/