linux-kernel - Re: Unexpected splice "always copy" behavior observed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 May 2010 13:59:16 -0700 (PDT)
From:	Rick Sherm <rick.sherm@...oo.com>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, arjan@...radead.org,
	linux-mm@...ck.org
Subject: Re: Unexpected splice "always copy" behavior observed

Sorry for deleting CC'd addresses. yahoo was whining...

--- On Wed, 5/19/10, Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Subject: Re: Unexpected splice "always copy" behavior observed
> To: "Steven Rostedt" <rostedt@...dmis.org>
> Cc: "Nick Piggin" <npiggin@...e.de>, "Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>, "Peter Zijlstra" <peterz@...radead.org>, "Frederic Weisbecker" <fweisbec@...il.com>, "Pierre Tardy" <tardyp@...il.com>, "Ingo Molnar" <mingo@...e.hu>, "Arnaldo Carvalho de Melo" <acme@...hat.com>, "Tom Zanussi" <tzanussi@...il.com>, "Paul Mackerras" <paulus@...ba.org>, linux-kernel@...r.kernel.org, arjan@...radead.org, ziga.mahkovec@...il.com, "davem" <davem@...emloft.net>, linux-mm@...ck.org, "Andrew Morton" <akpm@...ux-foundation.org>, "KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>, "Christoph Lameter" <cl@...ux-foundation.org>, "Tejun Heo" <tj@...nel.org>, "Jens Axboe" <jens.axboe@...cle.com>
> Date: Wednesday, May 19, 2010, 2:59 PM
> 
> 
> On Wed, 19 May 2010, Steven Rostedt wrote:
> 
> > On Wed, 2010-05-19 at 07:39 -0700, Linus Torvalds
> wrote:
> > 
> > > The real limitation is likely always going to be
> the fact that it has to 
> > > be page-aligned and a full page. For a lot of
> splice inputs, that simply 
> > > won't be the case, and you'll end up copying for
> alignment reasons anyway.
> > 
> > That's understandable. For the use cases of splice I
> use, I work to make
> > it page aligned and full pages. Anyone else using
> splice for
> > optimizations, should do the same. It only makes
> sense.
> > 
> > The end of buffer may not be a full page, but then
> it's the end anyway,
> > and I'm not as interested in the speed.
> 
> Btw, since you apparently have a real case - is the "splice
> to file" 
> always just an append? IOW, if I'm not right in assuming
> that the only 
> sane thing people would reasonable care about is "append to
> a file", then 
> holler now.
> 

I've a similar 'append' use case:
http://marc.info/?l=linux-kernel&m=127143736527459&w=4

My mmapped buffers are pinned down.


      

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/