linux-kernel - Re: [PATCH 07/13] jump label v8: sort jump table at build-time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 May 2010 15:36:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jbaron@...hat.com
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	mathieu.desnoyers@...ymtl.ca, hpa@...or.com, tglx@...utronix.de,
	rostedt@...dmis.org, andi@...stfloor.org, roland@...hat.com,
	rth@...hat.com, mhiramat@...hat.com, fweisbec@...il.com,
	avi@...hat.com, vgoyal@...hat.com
Subject: Re: [PATCH 07/13] jump label v8: sort jump table at build-time

From: Jason Baron <jbaron@...hat.com>
Date: Wed, 19 May 2010 12:22:17 -0400

> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 2092361..fe6f8be 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -17,6 +17,8 @@
>  #include "modpost.h"
>  #include "../../include/generated/autoconf.h"
>  #include "../../include/linux/license.h"
> +#include <linux/types.h>
> +#include "jump_entry.h"
>  

This breaks the build on non-jump_label-supporting architectures
because only they will have the jump_entry.h header file.

I'm really getting tired trying to test your changes and every single
time as I go through doing very basic build testing I always hit one
patch that assumes jump label support exists, or assumes some x86'ism.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/