linux-kernel - Re: Unexpected splice "always copy" behavior observed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1005191659100.23538@i5.linux-foundation.org>
Date:	Wed, 19 May 2010 17:04:07 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
cc:	Nick Piggin <npiggin@...e.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Miklos Szeredi <miklos@...redi.hu>, peterz@...radead.org,
	fweisbec@...il.com, tardyp@...il.com, mingo@...e.hu,
	acme@...hat.com, tzanussi@...il.com, paulus@...ba.org,
	linux-kernel@...r.kernel.org, arjan@...radead.org,
	ziga.mahkovec@...il.com, davem@...emloft.net, linux-mm@...ck.org,
	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	cl@...ux-foundation.org, tj@...nel.org, jens.axboe@...cle.com
Subject: Re: Unexpected splice "always copy" behavior observed



On Wed, 19 May 2010, Mathieu Desnoyers wrote:
> 
> A faced a small counter-intuitive fadvise behavior though.
> 
>   posix_fadvise(fd, 0, 0, POSIX_FADV_DONTNEED);
> 
> only seems to affect the parts of a file that already exist.

POSIX_FADV_DONTNEED does not have _any_ long-term behavior. So when you do 
a 

	posix_fadvise(fd, 0, 0, POSIX_FADV_DONTNEED);

it only affects the pages that are there right now, it has no effect on 
any future actions.

> So after each splice() that appends to the file, I have to call fadvise 
> again. I would have expected the "0" len parameter to tell the kernel to 
> apply the hint to the whole file, even parts that will be added in the 
> future.

It's not a hint about future at all. It's a "throw current pages away".

I would also suggest against doing that kind of thing in a streaming write 
situation. The behavior for dirty page writeback is _not_ welldefined, and 
if you do POSIX_FADV_DONTNEED, I would suggest you do it as part of that 
writeback logic, ie you do it only on ranges that you have just waited on.

IOW, in my example, you'd couple the

	sync_file_range(fd, (index-1)*BUFSIZE, BUFSIZE, SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE|SYNC_FILE_RANGE_WAIT_AFTER);

with a

	posix_fadvise(fd, (index-1)*BUFSIZE, BUFSIZE, POSIX_FADV_DONTNEED);

afterwards to throw out the pages that you just waited for.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/