linux-kernel - Re: [PATCH 2/2] x86, mem-hotplug: update all PGDs for direct mapping and vmemmap mapping changes on 64bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 May 2010 11:52:01 +0800
From:	Haicheng Li <haicheng.li@...ux.intel.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] x86, mem-hotplug: update all PGDs for direct mapping
 and vmemmap mapping changes on 64bit.

Wu Fengguang wrote:
>> @@ -1033,6 +1038,7 @@ vmemmap_populate(struct page *start_page, unsigned long size, int node)
>>   		}
>>
>>   	}
>> +	sync_global_pgds((unsigned long)start_page, end);
> 
> Here you removed the tlb flush in the original patch. Is it safe to do so?

Yes, I think so. Before this populate, such vmemmap mapping should be always zero, so it's optional 
to do tlb flush here.

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/