linux-kernel - Re: [PATCH 5/8] USB: gadget: f_fs: use usb_string_ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vc1uksfa7p4s8u@pikus>
Date:	Fri, 21 May 2010 11:42:18 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	linux-usb@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] USB: gadget: f_fs: use usb_string_ids_n()

> Michal Nazarewicz wrote:
>> @@ -1393,25 +1396,17 @@ static int functionfs_bind(struct ffs_data *ffs, struct usb_composite_dev *cdev)
>>  	ffs->ep0req->complete = ffs_ep0_complete;
>>  	ffs->ep0req->context = ffs;
>>
>> -	/* Get strings identifiers */
>> -	for (count = ffs->strings_count, i = 0; i < count; ++i) {
>> -		struct usb_gadget_strings **lang;
>> -
>> -		int id = usb_string_id(cdev);
>> -		if (unlikely(id < 0)) {
>> -			usb_ep_free_request(cdev->gadget->ep0, ffs->ep0req);
>> -			ffs->ep0req = NULL;
>> -			return id;
>> +	lang = ffs->stringtabs;
>> +	while (*lang) {
>> +		struct usb_string *str = (*lang)->strings;
>> +		int id = first_id;
>> +		for (; str->s; ++id, ++str) {
>> +			str->id = id;
>>  		}

On Thu, 20 May 2010 19:01:51 +0200, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
>     {} not needed here.

Thanks.

I'll wait for some other comments and resend the patchset
or this single patch or whatever will be appropriate.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/