lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 May 2010 12:24:37 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 2/2] perf: Drop the skip argument from
 perf_arch_fetch_regs_caller

On Fri, 2010-05-21 at 10:11 +0200, Frederic Weisbecker wrote:
> +static inline void perf_fetch_caller_regs(struct pt_regs *regs)
>  {
> -       unsigned long ip;
> -
>         memset(regs, 0, sizeof(*regs));

btw, do we really need that memset?

As long as we don't actually copy out to userspace, it really doesn't
matter what is in there, and we should be setting all relevant registers
anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists