lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 May 2010 18:53:54 +0400 From: Konstantin Khlebnikov <khlebnikov@...allels.com> To: Jens Axboe <axboe@...nel.dk> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Dmitry Monakhov <dmonakhov@...nvz.org> Subject: Re: [PATCH 1/2] cfq-iosched: remove dead_key from cfq_io_context On 21.05.2010 13:40, Jens Axboe wrote: > On Thu, May 20 2010, Konstantin Khlebnikov wrote: >> Remove ->dead_key field from cfq_io_context to shrink its size to 128 bytes. >> (64 bytes for 32-bit hosts) >> >> Use lower bit in ->key as dead-mark, instead of moving key to separate field. >> After this for dead cfq_io_context we got cic->key != cfqd automatically. >> Thus, io_context's last-hit cache should work without changing. >> >> Now to check ->key for non-dead state compare it with cfqd, >> instead of checking ->key for non-null value as it was before. >> >> Plus remove obsolete race protection in cfq_cic_lookup. >> This race gone after v2.6.24-1728-g4ac845a > > This, and the second patch, look really good. How much testing have you > done with it? > I have run multiple fsstress and simultaneously switch io-scheduler in loop for several hours, no oopses and leaks detected. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists