linux-kernel - Re: [PATCH] online CPU before memory failed in pcpu_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100521134424.45e0ee36.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 21 May 2010 13:44:24 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	minskey guo <chaohong_guo@...ux.intel.com>, linux-mm@...ck.org,
	prarit@...hat.com, andi.kleen@...el.com,
	linux-kernel@...r.kernel.org, minskey guo <chaohong.guo@...el.com>,
	Tejun Heo <tj@...nel.org>, stable@...nel.org
Subject: Re: [PATCH] online CPU before memory failed in pcpu_alloc_pages()

On Fri, 21 May 2010 10:55:12 +1000
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi Andrew,
> 
> On Thu, 20 May 2010 13:43:59 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > > --- a/mm/percpu.c
> > > +++ b/mm/percpu.c
> > > @@ -714,13 +714,29 @@ static int pcpu_alloc_pages(struct pcpu_chunk *chunk,
> > 
> > In linux-next, Tejun has gone and moved pcpu_alloc_pages() into the new
> > mm/percpu-vm.c.  So either
> 
> This has gone into Linus' tree today ...
> 

Hmm, a comment here.

Recently, Lee Schermerhorn developed

 numa-introduce-numa_mem_id-effective-local-memory-node-id-fix2.patch

Then, you can use cpu_to_mem() instead of cpu_to_node() to find the
nearest available node.
I don't check cpu_to_mem() is synchronized with NUMA hotplug but
using cpu_to_mem() rather than adding 
=

+			if ((nid == -1) ||
+			    !(node_zonelist(nid, GFP_KERNEL)->_zonerefs->zone))
+				nid = numa_node_id();
+
==

is better. 

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/