linux-kernel - Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100521115718.552d50dd.akpm@linux-foundation.org>
Date:	Fri, 21 May 2010 11:57:18 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	"Li, Shaohua" <shaohua.li@...el.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Hugh Dickins <hughd@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at
 first

On Fri, 21 May 2010 09:36:50 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > Reviewed-by: Wu Fengguang <fengguang.wu@...el.com>
> > 
> > The preceding comment "they need to go on the active_anon lru below"
> > also needs update.
> > 
> 
> Thanks. incremental patch is here.
> 
> 
> ---
>  include/linux/swap.h |   10 ----------
>  mm/filemap.c         |    2 +-
>  2 files changed, 1 insertions(+), 11 deletions(-)
> 
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 18420a9..4bfd932 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -224,21 +224,11 @@ static inline void lru_cache_add_anon(struct page *page)
>  	__lru_cache_add(page, LRU_INACTIVE_ANON);
>  }
>  
> -static inline void lru_cache_add_active_anon(struct page *page)
> -{
> -	__lru_cache_add(page, LRU_ACTIVE_ANON);
> -}
> -
>  static inline void lru_cache_add_file(struct page *page)
>  {
>  	__lru_cache_add(page, LRU_INACTIVE_FILE);
>  }
>  
> -static inline void lru_cache_add_active_file(struct page *page)
> -{
> -	__lru_cache_add(page, LRU_ACTIVE_FILE);
> -}

Did you intend to remove these two functions?

They do appear to be unused now, but they still make sense and might be
used in the future, perhaps.  It's OK to remove them, but I'm wondering
if it was deliberately included in this patch?


>  /* LRU Isolation modes. */
>  #define ISOLATE_INACTIVE 0	/* Isolate inactive pages. */
>  #define ISOLATE_ACTIVE 1	/* Isolate active pages. */
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 023ef61..a57931a 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -441,7 +441,7 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
>  	/*
>  	 * Splice_read and readahead add shmem/tmpfs pages into the page cache
>  	 * before shmem_readpage has a chance to mark them as SwapBacked: they
> -	 * need to go on the active_anon lru below, and mem_cgroup_cache_charge
> +	 * need to go on the anon lru below, and mem_cgroup_cache_charge
>  	 * (called in add_to_page_cache) needs to know where they're going too.
>  	 */
>  	if (mapping_cap_swap_backed(mapping))
> -- 
> 1.6.5.2
> 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/