linux-kernel - Re: [PATCH] get_maintainer.pl: improve config-file support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100521230823.7f0a0200@schatten.dmk.lab>
Date:	Fri, 21 May 2010 23:08:23 +0200
From:	Florian Mickler <florian@...kler.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Hemminger <shemminger@...tta.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] get_maintainer.pl: improve config-file support

On Fri, 21 May 2010 13:21:28 -0700
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2010-05-21 at 13:13 -0700, Andrew Morton wrote:
> > On Thu, 20 May 2010 08:46:15 +0200
> > Florian Mickler <florian@...kler.org> wrote:
> > > What's the status of this patch?
> > > Do you take it, or do you have an issue with it? This is a clear
> > > improvement in my opinion.
> > Joe didn't sound very excited about it.
> > If we're going to do this, we should hurry up, please - it'd be silly
> > to introduce a config file and then change its format shortly
> > afterwards.
> 
> If an ".ini" style config is used, I think it'd be better to
> put this stuff in .git/config under a proper section so that
> any checking style script (checkpatch, smatch, smpl, etc)
> has a standard place to put stuff.
> 
> I think what I posted requires less overall work and doesn't
> need updating every time a new option is added, but overall
> the capability isn't all that necessary.

Feature-like it is the same. But in my opinion my solution with a
key=value approach (why .ini? where did you get that from?) is more
obvious. 
I've never seen this hacky thing where you put "--option" tokens in
a file in my life. 
Of course, Joe's solution is short and to the point.
But i would consider it more "quick'n'dirty" than elegant.

As for the placement:
This has nothing to do with git, aside from using it as a _possible_
way to determine the maintainers. So I doubt that we should
mess with .git/config. If you want to go that road of a more general
solution, a common /scripts/ config-file would be more realistic.

Cheers,
Flo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/