linux-kernel - Re: [PATCH -next] nouveau: fix acpi_lid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1274659763.2385.24.camel@localhost.localdomain>
Date:	Mon, 24 May 2010 10:09:23 +1000
From:	Ben Skeggs <bskeggs@...hat.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	dri-devel@...ts.freedesktop.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH -next] nouveau: fix acpi_lid_open undefined

On Sun, 2010-05-23 at 17:00 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled)
> and NOUVEAU is built-in (not as a loadable module):
> 
> nouveau_connector.c:(.text+0xe17ce): undefined reference to `acpi_lid_open'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Acked-by: Ben Skeggs <bskeggs@...hat.com>

> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100522.orig/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ linux-next-20100522/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -241,7 +241,8 @@ nouveau_connector_detect(struct drm_conn
>  	if (nv_encoder && nv_connector->native_mode) {
>  		unsigned status = connector_status_connected;
>  
> -#ifdef CONFIG_ACPI
> +#if defined(CONFIG_ACPI_BUTTON) || \
> +	(defined(CONFIG_ACPI_BUTTON_MODULE) && defined(MODULE))
>  		if (!nouveau_ignorelid && !acpi_lid_open())
>  			status = connector_status_unknown;
>  #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/