lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100524111457.GB16756@pengutronix.de>
Date:	Mon, 24 May 2010 13:14:57 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Jiri Slaby <jslaby@...e.cz>, Dmitry Torokhov <dtor@...l.ru>,
	Devin Heitmueller <dheitmueller@...nellabs.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers/media/dvb/dvb-usb/dib0700: fix return
	values

On Mon, May 24, 2010 at 12:57:14PM +0200, Daniel Mack wrote:
> Propagte correct error values instead of returning -1 which just means
> -EPERM ("Permission denied")
> 
> Signed-off-by: Daniel Mack <daniel@...aq.de>
> Cc: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc: Jiri Slaby <jslaby@...e.cz>
> Cc: Dmitry Torokhov <dtor@...l.ru>
> Cc: Devin Heitmueller <dheitmueller@...nellabs.com>
> Cc: linux-media@...r.kernel.org

I am no specialist for this driver, but as I am on cc and it looks good to me
(no big changes, after all):

Acked-by: Wolfram Sang <w.sang@...gutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ